Display error if editing non-current order #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDutil
commented
Oct 23, 2019
JDutil
force-pushed
the
fixes-2078
branch
5 times, most recently
from
5e8d7fd to
a16cb2f
Compare
kennyadsl
reviewed
Oct 25, 2019
houndci-bot
reviewed
Oct 29, 2019
JDutil
force-pushed
the
fixes-2078
branch
2 times, most recently
from
1d31f07 to
df940bd
Compare
Users can input any order id within the orders controller routing, but we simply render the cart with the current order. This can cause some users confusion if they are expecting to edit an existing order after viewing it's receipt. So let's simply display a flash message indicating you cannot edit existing orders if the routing id does not match the current order.
kennyadsl
approved these changes
Nov 6, 2019
ericsaupe
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can input any order id within the orders controller routing, but
we simply render the cart with the current order. This can cause some
users confusion if they are expecting to edit an existing order after
viewing it's receipt.
So let's simply display a flash message indicating you cannot edit
existing orders if the routing id does not match the current order.
fixes #2078
Checklist: